fix(previews): Don't crash on animated WEBP images #38364
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
szaimen
requested review from
rullzer,
fancycode,
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
|
Why not just create a preview provider to do this magic? OC_Image is one of those classes that still needs to die IMO. |
|
Well yeah (#28279 et al + Imaginary support etc), but this PR just fixes what is still a common/still supported setup (particularly in small deployments). P.S. Is there an official deprecation of OC_Image preview generation? I thought it fell more into the category "we know it's coming, things are happening to build up to it, but not yet deprecated" 👀 |
|
WebP preview provider: https://github.com/nextcloud/server/blob/master/lib/private/Preview/WebP.php Currently the generic implementation, using OC_Image, is used to generate previews for WebP. |
AndyScherzinger
force-pushed
the
jr-preview-libgd-webp-animation-bypass
branch
from
510ca8a
to
edf8ca6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@ytoaa Can you elaborate? What are you experiencing when you're testing this PR doing in your environment? |
joshtrichards
force-pushed
the
jr-preview-libgd-webp-animation-bypass
branch
from
edf8ca6
to
7943ad6
Compare
joshtrichards
changed the title
Oh I think I'm mistaken. When will this merge into the main release? |
|
@joshtrichards Please squash and use a conventional commit message. E.g. |
joshtrichards
force-pushed
the
jr-preview-libgd-webp-animation-bypass
branch
from
8cc107f
to
cff4727
Compare
|
/backport to stable29 |
|
/backport to stable28 |
joshtrichards
changed the title
joshtrichards
force-pushed
the
jr-preview-libgd-webp-animation-bypass
branch
3 times, most recently
from
bc97193
to
e2aaf27
Compare
Fixes nextcloud#30029 and nextcloud#37263 libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too. Signed-off-by: Josh Richards <josh.t.richards@gmail.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
jr-preview-libgd-webp-animation-bypass
branch
from
e2aaf27
to
046fe8d
Compare
|
I don't get why cypress keeps failing. Could this be because the action is run from a fork? |
Yes iirc our cypress setup does not support forks |
|
Alright, thanks for clarifying. @joshtrichards I'm sorry for the inconvenience but do you mind opening another PR from a branch on this repository directly? AFAIK, you should have permissions to do so. |
skjnldsv
added
4. to release
Summary
libgd handles animated WEBP images poorly (fatal error and generates a meaningless/misleading error message). As a result we were returning a 500 error for these
/previewrequests (web) and a fatal error at the command-line (occ). Now we bypass libgd if we detect an animated WEBP image and simply don't generate the preview. No more 500 error. Should fixocctoo.The prospect of incorporating animation handling is an upstream matter:
libgd/libgd#648
https://bugs.php.net/bug.php?id=79809
https://www.php.net/manual/en/function.imagecreatefromwebp.php
TODO
Checklist