Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carddav): Don't show system address book cards to guests #38448

Merged
merged 1 commit into from
May 25, 2023
Merged

fix(carddav): Don't show system address book cards to guests #38448

merged 1 commit into from
May 25, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 24, 2023 •
edited
Loading

Summary

Guests should not see other users in the system address book

TODO

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 24, 2023
@ChristophWurst ChristophWurst self-assigned this May 24, 2023
@ChristophWurst ChristophWurst changed the title Fix/carddav/no sab guest users fix(carddav): Don't show system address book cards to guests May 24, 2023
@ChristophWurst ChristophWurst mentioned this pull request May 25, 2023
Merged
10 tasks
@ChristophWurst ChristophWurst force-pushed the fix/carddav/no-sab-guest-users branch from e750762 to 9955c0d Compare May 25, 2023 10:06
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 25, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst ChristophWurst marked this pull request as ready for review May 25, 2023 10:06
@ChristophWurst
fix(carddav): Don't show system address book cards to guests
e524631 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/carddav/no-sab-guest-users branch from 9955c0d to e524631 Compare May 25, 2023 10:26
hamza221
hamza221 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 25, 2023
@blizzz blizzz enabled auto-merge May 25, 2023 13:55
@blizzz blizzz merged commit cd5bd11 into master May 25, 2023
@blizzz blizzz deleted the fix/carddav/no-sab-guest-users branch May 25, 2023 15:26
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

(bot is not very responsive today)

@blizzz
Copy link
Member

blizzz commented May 25, 2023

perhaps Manuel can help

@blizzz blizzz mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld left review comments

@JohannesGGE JohannesGGE JohannesGGE approved these changes

@hamza221 hamza221 hamza221 approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@blizzz blizzz Awaiting requested review from blizzz

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: carddav Related to CardDAV internals feature: dav feature: users and groups
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @blizzz @nickvergessen @tcitworld @hamza221 @JohannesGGE