Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Fix avatar size in system address book #38481

Merged
merged 1 commit into from
May 26, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 26, 2023

Summary

Before our server went away on a 14MB avatar:

In Connection.php line 123:
                                                                   
  SQLSTATE[HY000]: General error: 2006 MySQL server has gone away  
                                                                   

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label May 26, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone May 26, 2023
@nickvergessen nickvergessen self-assigned this May 26, 2023
@ChristophWurst
Copy link
Member

/backport to stable27

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 26, 2023
@nickvergessen nickvergessen merged commit 37f387b into master May 26, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/avatar-size-in-sab branch May 26, 2023 09:04
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@nickvergessen
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: carddav Related to CardDAV internals feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants