Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved display of app links #38520

Merged
merged 2 commits into from
May 30, 2023

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented May 30, 2023

Respawn of #37823

Before :

2023-05-30_17-01

After :

2023-05-30_16-56

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen requested review from jancborchardt, Pytal, nimishavijay, a team, susnux and Fenn-CS and removed request for a team May 30, 2023 14:38
@szaimen szaimen added this to the Nextcloud 28 milestone May 30, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label May 30, 2023
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen enabled auto-merge May 30, 2023 14:39
@Jerome-Herbinet
Copy link
Member Author

May it be added to Nextcloud 27 Milestone ?

@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

May it be added to Nextcloud 27 Milestone ?

you can summon the backport for this

@Jerome-Herbinet
Copy link
Member Author

May it be added to Nextcloud 27 Milestone ?

you can summon the backport for this

Hmmm, I've never done that before ; can you tell me the method ? @szaimen

@Jerome-Herbinet
Copy link
Member Author

May it be added to Nextcloud 27 Milestone ?

you can summon the backport for this

Hmmm, I've never done that before ; can you tell me the method ? @szaimen

This way ?
Capture d’écran du 2023-05-30 16-44-22

@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

This way ?

No, the milestone should stay Nextcloud 28. But you can summon the backport bot by so:

@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

/backport to stable27

@Fenn-CS
Copy link
Contributor

Fenn-CS commented May 30, 2023

@Jerome-Herbinet /backport to stable27 (as comment here would do)

@Jerome-Herbinet
Copy link
Member Author

/backport to stable27

Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots?

@Jerome-Herbinet
Copy link
Member Author

@Jerome-Herbinet /backport to stable27 (as comment here would do)

Thanks :-)

@Jerome-Herbinet
Copy link
Member Author

screenshots?

2023-05-30_16-56

@Jerome-Herbinet Jerome-Herbinet added the design Design, UI, UX, etc. label May 30, 2023
@Fenn-CS
Copy link
Contributor

Fenn-CS commented May 30, 2023

Thanks @Jerome-Herbinet just to add that, when you are adding a screen add the before and after. Also you can add it as part of the original PR description (or first comment).

Thanks for the work!

@Jerome-Herbinet
Copy link
Member Author

Thanks @Jerome-Herbinet just to add that, when you are adding a screen add the before and after. Also you can add it as part of the original PR description (or first comment).

Thanks for the work!

Yep you are right, I did all that in a bit of a rush, sorry.

Before :
2023-05-30_17-01

@Jerome-Herbinet
Copy link
Member Author

Thanks @Jerome-Herbinet just to add that, when you are adding a screen add the before and after. Also you can add it as part of the original PR description (or first comment).
Thanks for the work!

Yep you are right, I did all that in a bit of a rush, sorry.

Before : 2023-05-30_17-01

@Fenn-CS I updated the top first comment with the "before" and "after" screenshot.

@szaimen szaimen disabled auto-merge May 30, 2023 15:43
@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

CI failure unrelated afaics

@szaimen szaimen merged commit 41314d3 into master May 30, 2023
@szaimen szaimen deleted the Jerome-Herbinet-improved-display-of-app-links branch May 30, 2023 15:44
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor

szaimen commented May 30, 2023

/backport e25fb29 to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants