Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dispatcher): Migrate to OCP event dispatcher before symfony/event… #38545

Merged

Conversation

nickvergessen
Copy link
Member

…-dispatcher upgrade

Summary

Required for the upcoming symfony/event-dispatcher upgrade which breaks their API.
Also raised in apps:

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels May 31, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone May 31, 2023
@nickvergessen nickvergessen requested review from ChristophWurst, come-nc and a team May 31, 2023 12:18
@nickvergessen nickvergessen self-assigned this May 31, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl and icewind1991 and removed request for a team May 31, 2023 12:18
@nickvergessen nickvergessen force-pushed the bugfix/noid/symfony/event-dispatcher-upgrade-preparation branch 2 times, most recently from 2a13730 to 4abc53a Compare June 1, 2023 20:26
…-dispatcher upgrade

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/symfony/event-dispatcher-upgrade-preparation branch from 4abc53a to 6d076c1 Compare June 2, 2023 06:08
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit fa4f476 into master Jun 2, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/symfony/event-dispatcher-upgrade-preparation branch June 2, 2023 07:51
@nickvergessen
Copy link
Member Author

/backport 6793fe1 to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@nickvergessen
Copy link
Member Author

Done in #40101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants