Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set background = backgroundColor via occ #38631

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 3, 2023

Summary

Before:

$ occ theming:config background backgroundColor
The image file needs to be provided as an absolute path: backgroundColor.

After:

$ occ theming:config background backgroundColor       
Updated backgroundMime to backgroundColor

TODO

  • CI

Checklist

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Jun 3, 2023
@kesselb kesselb self-assigned this Jun 3, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jun 3, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Jun 6, 2023

This feels a bit undiscoverable, but fair enough :)

@kesselb
Copy link
Contributor Author

kesselb commented Jun 6, 2023

This feels a bit undiscoverable, but fair enough :)

True ;)

Sorry, I forgot to mention the pull request to update the documentation: nextcloud/documentation#10569

I will send another to document occ theming:config background backgroundColor after merge.

@kesselb kesselb added the pending documentation This pull request needs an associated documentation update label Jun 6, 2023
@kesselb kesselb merged commit fd7d0e2 into master Jun 6, 2023
@kesselb kesselb deleted the theming-set-background-color-via-occ branch June 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants