fix: install vfsStream to run testMimeTypeIcon again #38632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added
2. developing
kesselb
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
Merged
|
Moving to 29 |
|
afaik content based detection is no longer used and the methods should be deprecated and removed |
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I had in mind to use vfsStream to write a unit test for CacheMountProvider.
DetectionTest.testMimeTypeIcon is using vfsStream.
11be3d6#diff-3502da4abe2721c4106a1bd15f035a4d0a9197e27899a0d73f9cac18adb323c8 broke the test.
I cannot say if we need the test. It did not run for at least 7 years 🙈
TODO
Checklist