Avoid requests to opengraph image if no host detected #38645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
3. to review
ChristophWurst
approved these changes
Jun 5, 2023
| $folder->newFile(md5($reference->getId()), $bodyStream->getContents()); | ||
| $reference->setImageUrl($this->urlGenerator->linkToRouteAbsolute('core.Reference.preview', ['referenceId' => md5($reference->getId())])); | ||
| $host = parse_url($object->images[0]->url, PHP_URL_HOST); | ||
| if ($host === false || $host === null) { |
There was a problem hiding this comment.
nit: return early to avoid indentation
There was a problem hiding this comment.
I did that on purpose to avoid creating issues if we ever append something to this method and forget about the early return.
juliushaertl
approved these changes
Jun 5, 2023
julien-nc
force-pushed
the
enh/noid/link-ref-provider-local-image-uri
branch
2 times, most recently
from
28f0fc6
to
198b681
Compare
ChristophWurst
added
4. to release
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/link-ref-provider-local-image-uri
branch
from
198b681
to
3621a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
LinkReferenceProviderto resolvehttps://www.compart.com/en/unicode/U+033C, for example, the OpenGraph image URI is/en/unicode/images/icon/icon-compart.svg. It is kind of fine because our HTTP client refuses to make requests when there is no host.We might want to improve this.
With this PR, we don't make a request if no host is detected.
Maybe we even want to forbid local addresses regardless of the
allow_local_remote_serverssystem config. What do you think?PS: The "previews and thumbnails" label is not exactly appropriate but it's the most fitting 😁