fix(weather_status): Always show all favorite locations #38664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
jancborchardt,
JuliaKirschenheuter,
a team,
artonge,
Pytal and
szaimen
and removed request for
a team
jancborchardt
approved these changes
Jun 6, 2023
susnux
force-pushed
the
fix/a11y-favorites-weather_status
branch
from
a3633a8
to
39b16fa
Compare
artonge
approved these changes
Jun 6, 2023
susnux
force-pushed
the
fix/a11y-favorites-weather_status
branch
from
0f204dd
to
cb6d42d
Compare
JuliaKirschenheuter
approved these changes
Jun 7, 2023
JuliaKirschenheuter
approved these changes
Jun 7, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/a11y-favorites-weather_status
branch
from
cb6d42d
to
bab7cc9
Compare
|
cypress error unrelated |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As suggested by @jancborchardt in nextcloud-libraries/nextcloud-vue#4168 (review) this removes the accordion button for the weather location favorites and simply always shows all favorites. (As the button is removed the a11y issue is also solved).
Screenshots
Checklist