Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apache): Serve mjs (module javascript) as static files #38688

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(apache): Serve mjs (module javascript) as static files #38688

merged 1 commit into from
Jun 7, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 7, 2023 •
edited
Loading

Summary

For apache to serve the module javascript files we need to add it to the rewrite rules (and to the caching rules).

Checklist

@susnux
fix(apache): Serve mjs (module javascript) as static files
e532419 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Jun 7, 2023
@susnux susnux added this to the Nextcloud 27 milestone Jun 7, 2023
@susnux susnux requested review from danxuliu, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team June 7, 2023 13:25
@susnux
Copy link
Contributor Author

susnux commented Jun 7, 2023

Nginx docs: nextcloud/documentation#10575

@susnux
Copy link
Contributor Author

susnux commented Jun 7, 2023

/backport to stable27

szaimen
szaimen approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen modified the milestones: Nextcloud 27, Nextcloud 28 Jun 7, 2023
@kesselb
Copy link
Contributor

kesselb commented Jun 7, 2023

CI failure unrelated.

@kesselb kesselb merged commit 42a1e82 into master Jun 7, 2023
@kesselb kesselb deleted the fix/serve-mjs-as-static-file branch June 7, 2023 16:41
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 7, 2023
Merged
@kesselb kesselb mentioned this pull request Jun 8, 2023
Merged
@susnux susnux mentioned this pull request Jul 17, 2023
Merged
26 tasks
MichaIng added a commit to MichaIng/DietPi that referenced this pull request Dec 2, 2023
@MichaIng
v8.25
cb2fc60 
- DietPi-Software | Nextcloud: Update Lighttpd and Nginx configs, especially add .mjs files to list of static resources: nextcloud/server#38688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@szaimen szaimen szaimen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @kesselb @szaimen