Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop meta robots header #38725

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Drop meta robots header #38725

merged 1 commit into from
Jun 12, 2023

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 9, 2023

Summary

X-Robots-Tag is already set everywhere where possible (here and here and here and also here) and fully supported by all major crawlers (Google, Yahoo, Bing, Yandex...) so it should be fully safe to avoid inject this meta header.

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Jun 9, 2023
@solracsf solracsf requested a review from MichaIng June 9, 2023 16:03
@solracsf solracsf added this to the Nextcloud 28 milestone Jun 9, 2023
Revert mistake

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf changed the title Drop meta robots tag Drop meta robots header Jun 9, 2023
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading into this meta tag vs header question some years ago, result was as well that the tag is redundant if the header is set, and the header should be preferred. In combination with the admin panel checks, to warn admins if the header is for some reason not set, this should be fine.

@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team June 10, 2023 06:42
@szaimen szaimen merged commit 1001adc into master Jun 12, 2023
@szaimen szaimen deleted the dropMetaRobots branch June 12, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Settings pages contain robots meta tag multiple times
4 participants