Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable #38777

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable #38777

merged 1 commit into from
Jun 13, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 12, 2023 •
edited
Loading

Summary

Make PHP happy.

TODO

  • Do

Checklist

@ChristophWurst
fix(carddav): Make SystemAddressBook::__construct $groupManager argum…
62c4196 
…ent nullable

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Jun 12, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Jun 12, 2023
@ChristophWurst ChristophWurst self-assigned this Jun 12, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst ChristophWurst mentioned this pull request Jun 12, 2023
Closed
8 tasks
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2023
@st3iny
Copy link
Member

st3iny commented Jun 13, 2023

CI failure seems to be unrelated. Some jobs fail with: phpunit: command not found

@ChristophWurst ChristophWurst merged commit 3f766e9 into master Jun 13, 2023
@ChristophWurst ChristophWurst deleted the fix/carddav/system-address-book-nullable-groupmanager branch June 13, 2023 10:40
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala miaulalala approved these changes

@hamza221 hamza221 hamza221 approved these changes

@JohannesGGE JohannesGGE Awaiting requested review from JohannesGGE

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
4 participants
@ChristophWurst @st3iny @miaulalala @hamza221