Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin setup-php to avoid a regression #38781

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 12, 2023

Temporarily, until shivammathur/setup-php#743 is solved.

Those files are not (at least not all 😅) distributed via our workflow-templates.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Jun 12, 2023
@blizzz blizzz added this to the Nextcloud 28 milestone Jun 12, 2023
@blizzz
Copy link
Member Author

blizzz commented Jun 12, 2023

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jun 12, 2023

/backport to stable26

@blizzz
Copy link
Member Author

blizzz commented Jun 12, 2023

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Jun 12, 2023

Lint php-cs apparently alao needs a pinning...

@szaimen
Copy link
Contributor

szaimen commented Jun 12, 2023

Apparently shivammathur/setup-php#743 is now already fixed

@solracsf
Copy link
Member

@skjnldsv
Copy link
Member

We still should pin as security measure.
We're doing it in the templates too

@szaimen
Copy link
Contributor

szaimen commented Jun 13, 2023

So merge?

@skjnldsv skjnldsv merged commit 39b716c into master Jun 13, 2023
@skjnldsv skjnldsv deleted the ci/noid/pin-setup-php branch June 13, 2023 07:29
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants