feat: remove orphaned entries from filecache_extended

[kesselb]

• Resolves: #

Summary

Test scenario:

• Run sql: select * from oc_filecache_extended left join oc_filecache on oc_filecache_extended.fileid = oc_filecache.fileid where oc_filecache.fileid is null;
• Mount an external storage (e.g. local)
• Upload some files to the external storage
• Delete external storage
• Run sql: select * from oc_filecache_extended left join oc_filecache on oc_filecache_extended.fileid = oc_filecache.fileid where oc_filecache.fileid is null;
• See files without a matching record in filecache

server/lib/private/Files/Cache/Storage.php

Line 222 in e69c7c4

public static function cleanByMountId(int $mountId) {

Best would be to clear filecache_extended when deleting the storage.

TODO

• OCI
• CI

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[juliushaertl]

Any reason to not make this run by default?

[kesselb]

Technically, no. The execution for the left join seems quick, but I only tested with ~1000 files.

My motivation, to hide it behind a flag, is my incomplete knowledge about filecache and especially external storages. However, I can't think of a case, why we would have a record in filecache_extended without a matching one in filecache.

We can run it by default if you think it should ;)

[icewind1991]

Switched to running it by default and having the flag disable it in case we ever find cases where that is required

[juliushaertl]

Code looks good, small question inside :)

[kesselb]

Moving to 29

[kesselb]

Howdy 👋

Thank you for taking care, I almost forgot about it 🙈

I don't remember if I tested it with OCI back then.
The chunking (for the OCI in clauses limit) is there.

[skjnldsv]

1) OCA\Files\Tests\Command\DeleteOrphanedFilesTest::testClearFiles
Expectation failed for method name is "writeln" when invoked 2 time(s)
Parameter 0 for invocation #1 Symfony\Component\Console\Output\OutputInterface::writeln('0 orphaned file cache extende...eleted', 0) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1 orphaned mount entries deleted'
+'0 orphaned file cache extended entries deleted'

[kesselb]

Moving to 30