Make no-user entry with avatar when there is no others with access

apps/comments/src/utils/cancelableRequest.js

@@ -39,7 +39,7 @@ const cancelableRequest = function(request) {
 	const fetch = async function(url, options) {
 		const response = await request(
 			url,
-			Object.assign({ signal }, options)
+			Object.assign({ signal }, options),
 		)
 		return response
 	}

apps/comments/src/views/Comments.vue

@@ -22,9 +22,9 @@
   -->
 
 <template>
-	<div class="comments"
-		:class="{ 'icon-loading': isFirstLoading }"
-		v-observe-visibility="onVisibilityChange">
+	<div v-observe-visibility="onVisibilityChange"
+		class="comments"
+		:class="{ 'icon-loading': isFirstLoading }">
 		<!-- Editor -->
 		<Comment v-bind="editorData"
 			:auto-complete="autoComplete"

apps/dav/src/dav/client.js

@@ -34,6 +34,6 @@ export const getClient = memoize((service) => {
 	patcher.patch('request', axios)
 
 	return webdav.createClient(
-		generateRemoteUrl(`dav/${service}/${getCurrentUser().uid}`)
+		generateRemoteUrl(`dav/${service}/${getCurrentUser().uid}`),
 	)
 })

apps/dav/src/service/PreferenceService.js

@@ -33,7 +33,7 @@ export async function enableUserStatusAutomation() {
 		}),
 		{
 			configValue: 'yes',
-		}
+		},
 	)
 }
 
@@ -45,6 +45,6 @@ export async function disableUserStatusAutomation() {
 		generateOcsUrl('/apps/provisioning_api/api/v1/config/users/{appId}/{configKey}', {
 			appId: 'dav',
 			configKey: 'user_status_automation',
-		})
+		}),
 	)
 }

apps/dav/src/settings.js

@@ -13,12 +13,12 @@ const CalDavSettingsView = new View({
 			sendInvitations: loadState('dav', 'sendInvitations'),
 			generateBirthdayCalendar: loadState(
 				'dav',
-				'generateBirthdayCalendar'
+				'generateBirthdayCalendar',
 			),
 			sendEventReminders: loadState('dav', 'sendEventReminders'),
 			sendEventRemindersToSharedUsers: loadState(
 				'dav',
-				'sendEventRemindersToSharedUsers'
+				'sendEventRemindersToSharedUsers',
 			),
 			sendEventRemindersPush: loadState('dav', 'sendEventRemindersPush'),
 		}

apps/dav/src/views/CalDavSettings.spec.js

@@ -50,27 +50,27 @@ describe('CalDavSettings', () => {
 			},
 			Vue => {
 				Vue.prototype.$t = jest.fn((app, text) => text)
-			}
+			},
 		)
 		expect(TLUtils.container).toMatchSnapshot()
 		const sendInvitations = TLUtils.getByLabelText(
-			'Send invitations to attendees'
+			'Send invitations to attendees',
 		)
 		expect(sendInvitations).toBeChecked()
 		const generateBirthdayCalendar = TLUtils.getByLabelText(
-			'Automatically generate a birthday calendar'
+			'Automatically generate a birthday calendar',
 		)
 		expect(generateBirthdayCalendar).toBeChecked()
 		const sendEventReminders = TLUtils.getByLabelText(
-			'Send notifications for events'
+			'Send notifications for events',
 		)
 		expect(sendEventReminders).toBeChecked()
 		const sendEventRemindersToSharedUsers = TLUtils.getByLabelText(
-			'Send reminder notifications to calendar sharees as well'
+			'Send reminder notifications to calendar sharees as well',
 		)
 		expect(sendEventRemindersToSharedUsers).toBeChecked()
 		const sendEventRemindersPush = TLUtils.getByLabelText(
-			'Enable notifications for events via push'
+			'Enable notifications for events via push',
 		)
 		expect(sendEventRemindersPush).toBeChecked()
 

apps/dav/src/views/CalDavSettings.vue

@@ -124,7 +124,7 @@ export default {
 			OCP.AppConfig.setValue(
 				'dav',
 				'sendInvitations',
-				value ? 'yes' : 'no'
+				value ? 'yes' : 'no',
 			)
 		},
 		sendEventReminders(value) {
@@ -134,7 +134,7 @@ export default {
 			OCP.AppConfig.setValue(
 				'dav',
 				'sendEventRemindersToSharedUsers',
-				value ? 'yes' : 'no'
+				value ? 'yes' : 'no',
 			)
 		},
 		sendEventRemindersPush(value) {

apps/files/src/components/NavigationQuota.vue

@@ -100,7 +100,7 @@ export default {
 		 * Update the storage stats
 		 * Throttled at max 1 refresh per minute
 		 *
-		 * @param {Event} [event = null] if user interaction
+		 * @param {Event} [event] if user interaction
 		 */
 		async updateStorageStats(event = null) {
 			if (this.loadingStorageStats) {

apps/files/src/components/TransferOwnershipDialogue.vue

@@ -37,8 +37,8 @@
 				<label for="targetUser">
 					<span>{{ t('files', 'New owner') }}</span>
 				</label>
-				<NcSelect input-id="targetUser"
-					v-model="selectedUser"
+				<NcSelect v-model="selectedUser"
+					input-id="targetUser"
 					:options="formatedUserSuggestions"
 					:multiple="false"
 					:loading="loadingUsers"

apps/files/src/services/FileAction.ts

@@ -46,13 +46,13 @@ interface FileActionData {
 	enabled?: (files: Node[], view: Navigation) => boolean
 	/**
 	 * Function executed on single file action
-	 * @returns true if the action was executed, false otherwise
+	 * @return true if the action was executed, false otherwise
 	 * @throws Error if the action failed
 	 */
 	exec: (file: Node, view: Navigation, dir: string) => Promise<boolean|null>,
 	/**
 	 * Function executed on multiple files action
-	 * @returns true if the action was executed successfully,
+	 * @return true if the action was executed successfully,
 	 * false otherwise and null if the action is silent/undefined.
 	 * @throws Error if the action failed
 	 */

apps/files/src/services/PreviewService.ts

@@ -25,6 +25,7 @@ const SWCacheName = 'previews'
 
 /**
  * Check if the preview is already cached by the service worker
+ * @param previewUrl
  */
 export const isCachedPreview = function(previewUrl: string) {
 	return caches.open(SWCacheName)

apps/files_external/tests/appSpec.js

@@ -1,5 +1,5 @@
 /**
-* @copyright 2014 Vincent Petry <pvince81@owncloud.com>
+ * @copyright 2014 Vincent Petry <pvince81@owncloud.com>
  *
  * @author Joas Schilling <coding@schilljs.com>
  * @author John Molakvoæ <skjnldsv@protonmail.com>
@@ -39,7 +39,7 @@ describe('OCA.Files_External.App tests', function() {
 			+ '<div id="app-content-extstoragemounts" class="hidden">'
 			+ '</div>'
 			+ '</div>'
-			+ '</div>'
+			+ '</div>',
 		)
 		fileList = App.initList($('#app-content-extstoragemounts'))
 	})

apps/files_sharing/src/components/SharingEntryLink.vue

@@ -671,7 +671,7 @@ export default {
 		 * accordingly
 		 *
 		 * @param {Share} share the new share
-		 * @param {boolean} [update=false] do we update the current share ?
+		 * @param {boolean} [update] do we update the current share ?
 		 */
 		async pushNewLinkShare(share, update) {
 			try {

apps/files_sharing/src/components/SharingEntrySimple.vue

@@ -29,8 +29,8 @@
 				{{ subtitle }}
 			</p>
 		</div>
-		<NcActions ref="actionsComponent"
-			v-if="$slots['default']"
+		<NcActions v-if="$slots['default']"
+			ref="actionsComponent"
 			class="sharing-entry__actions"
 			menu-align="right"
 			:aria-expanded="ariaExpandedValue">

apps/files_sharing/src/components/SharingInput.vue

@@ -24,6 +24,7 @@
 	<div class="sharing-search">
 		<label for="sharing-search-input">{{ t('files_sharing', 'Search for share recipients') }}</label>
 		<NcSelect ref="select"
+			v-model="value"
 			input-id="sharing-search-input"
 			class="sharing-search__input"
 			:disabled="!canReshare"
@@ -33,7 +34,6 @@
 			:clear-search-on-blur="() => false"
 			:user-select="true"
 			:options="options"
-			v-model="value"
 			@open="handleOpen"
 			@search="asyncFind"
 			@option:selected="addShare">
@@ -176,7 +176,7 @@ export default {
 		 * Get suggestions
 		 *
 		 * @param {string} search the search query
-		 * @param {boolean} [lookup=false] search on lookup server
+		 * @param {boolean} [lookup] search on lookup server
 		 */
 		async getSuggestions(search, lookup = false) {
 			this.loading = true

apps/files_sharing/src/mixins/ShareRequests.js

@@ -42,13 +42,13 @@ export default {
 		 * @param {string} data.path  path to the file/folder which should be shared
 		 * @param {number} data.shareType  0 = user; 1 = group; 3 = public link; 6 = federated cloud share
 		 * @param {string} data.shareWith  user/group id with which the file should be shared (optional for shareType > 1)
-		 * @param {boolean} [data.publicUpload=false]  allow public upload to a public shared folder
+		 * @param {boolean} [data.publicUpload]  allow public upload to a public shared folder
 		 * @param {string} [data.password]  password to protect public link Share with
-		 * @param {number} [data.permissions=31]  1 = read; 2 = update; 4 = create; 8 = delete; 16 = share; 31 = all (default: 31, for public shares: 1)
-		 * @param {boolean} [data.sendPasswordByTalk=false] send the password via a talk conversation
-		 * @param {string} [data.expireDate=''] expire the shareautomatically after
-		 * @param {string} [data.label=''] custom label
-		 * @param {string} [data.attributes=null] Share attributes encoded as json
+		 * @param {number} [data.permissions]  1 = read; 2 = update; 4 = create; 8 = delete; 16 = share; 31 = all (default: 31, for public shares: 1)
+		 * @param {boolean} [data.sendPasswordByTalk] send the password via a talk conversation
+		 * @param {string} [data.expireDate] expire the shareautomatically after
+		 * @param {string} [data.label] custom label
+		 * @param {string} [data.attributes] Share attributes encoded as json
 		 * @return {Share} the new share
 		 * @throws {Error}
 		 */
@@ -66,7 +66,7 @@ export default {
 				const errorMessage = error?.response?.data?.ocs?.meta?.message
 				OC.Notification.showTemporary(
 					errorMessage ? t('files_sharing', 'Error creating the share: {errorMessage}', { errorMessage }) : t('files_sharing', 'Error creating the share'),
-					{ type: 'error' }
+					{ type: 'error' },
 				)
 				throw error
 			}
@@ -91,7 +91,7 @@ export default {
 				const errorMessage = error?.response?.data?.ocs?.meta?.message
 				OC.Notification.showTemporary(
 					errorMessage ? t('files_sharing', 'Error deleting the share: {errorMessage}', { errorMessage }) : t('files_sharing', 'Error deleting the share'),
-					{ type: 'error' }
+					{ type: 'error' },
 				)
 				throw error
 			}
@@ -118,7 +118,7 @@ export default {
 					const errorMessage = error?.response?.data?.ocs?.meta?.message
 					OC.Notification.showTemporary(
 						errorMessage ? t('files_sharing', 'Error updating the share: {errorMessage}', { errorMessage }) : t('files_sharing', 'Error updating the share'),
-						{ type: 'error' }
+						{ type: 'error' },
 					)
 				}
 				const message = error.response.data.ocs.meta.message

apps/files_sharing/src/utils/SharedWithMe.js

@@ -33,7 +33,7 @@ const shareWithTitle = function(share) {
 				owner: share.ownerDisplayName,
 			},
 			undefined,
-			{ escape: false }
+			{ escape: false },
 		)
 	} else if (share.type === ShareTypes.SHARE_TYPE_CIRCLE) {
 		return t(
@@ -44,7 +44,7 @@ const shareWithTitle = function(share) {
 				owner: share.ownerDisplayName,
 			},
 			undefined,
-			{ escape: false }
+			{ escape: false },
 		)
 	} else if (share.type === ShareTypes.SHARE_TYPE_ROOM) {
 		if (share.shareWithDisplayName) {
@@ -56,7 +56,7 @@ const shareWithTitle = function(share) {
 					owner: share.ownerDisplayName,
 				},
 				undefined,
-				{ escape: false }
+				{ escape: false },
 			)
 		} else {
 			return t(
@@ -66,7 +66,7 @@ const shareWithTitle = function(share) {
 					owner: share.ownerDisplayName,
 				},
 				undefined,
-				{ escape: false }
+				{ escape: false },
 			)
 		}
 	} else {
@@ -75,7 +75,7 @@ const shareWithTitle = function(share) {
 			'Shared with you by {owner}',
 			{ owner: share.ownerDisplayName },
 			undefined,
-			{ escape: false }
+			{ escape: false },
 		)
 	}
 }