Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no longer accessible shares #39168

Closed
wants to merge 1 commit into from

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jul 5, 2023

When trying to access a share where the owner no longer has access to the source file, remove the share instead of only marking it as failed.

To test:

  • Setup user A, B and C. Create a groupfolder G and give A and B access to it.
  • User B uploads a file F to G and shares it with C
  • User A moves F outside G
  • C tries to download the file

Downside is that the share is now gone "forever" even if the owner re-gains access to the file. So I'm not sure if this is actually desired behavior

  • Do we actually want this?

An alternative solution would be to mark the share as unavailable somehow, show the state to the user and make the user choose whether to remove the share or complain to the admin/owner of the file to give him his access back.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 5, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Jul 5, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Fenn-CS and come-nc and removed request for a team July 5, 2023 14:33
@icewind1991
Copy link
Member Author

Also see #39170 for a command that admins can used for manual cleanup instead of automatic cleanup

@come-nc
Copy link
Contributor

come-nc commented Jul 6, 2023

Can you show screenshots for current situation on master?
It may be better to show the error, stating the owner of the share no longer have access to the file and let the user decide if they want to remove the share or not.

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants