Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor lib/private/OCS #39173

Merged
merged 1 commit into from
Feb 23, 2024
Merged

refactor lib/private/OCS #39173

merged 1 commit into from
Feb 23, 2024

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the classes in /lib/private/OCS namespace.

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding types to properties
  • Replacing qualifiers with imports

Checklist

@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 6, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 6, 2023
ChristophWurst
ChristophWurst approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@shdehnavi shdehnavi requested a review from skjnldsv July 14, 2023 12:14
@fsamapoor fsamapoor force-pushed the refactor_lib_private_ocs branch from 2d7d5aa to 99169fc Compare September 29, 2023 07:59
ChristophWurst
ChristophWurst approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into one commit

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@shdehnavi shdehnavi force-pushed the refactor_lib_private_ocs branch 2 times, most recently from 88a5356 to 5e043f9 Compare December 11, 2023 12:54
@shdehnavi
Copy link
Contributor Author

@ChristophWurst All commits squashed into one commit and all conflicts have been resolved.

@shdehnavi shdehnavi force-pushed the refactor_lib_private_ocs branch from 7bfd837 to 37ecaa7 Compare December 11, 2023 13:17
@ChristophWurst
Copy link
Member

Error: lib/private/OCS/Provider.php:42:3: UndefinedThisPropertyAssignment: Instance property OC\OCS\Provider::$appManager is not defined (see https://psalm.dev/040)
Error: lib/private/OCS/Provider.php:60:7: UndefinedThisPropertyFetch: Instance property OC\OCS\Provider::$appManager is not defined (see https://psalm.dev/041)

@shdehnavi shdehnavi force-pushed the refactor_lib_private_ocs branch from 44e2c39 to ade77a5 Compare December 12, 2023 11:34
@shdehnavi
Copy link
Contributor Author

@ChristophWurst Psalm errors have been addressed in the last commit.
Also, All commits are squashed into one commit.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@shdehnavi @skjnldsv
Refactor lib/private/ocs
09b3702 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Refactor lib/private/ocs

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Refactor lib/private/ocs

Co-authored-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Add adjustments based on the review

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

replace qualifier with an import

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

refactor lib/private/OCS

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@skjnldsv skjnldsv force-pushed the refactor_lib_private_ocs branch from ade77a5 to 09b3702 Compare February 23, 2024 14:54
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 14:54
@skjnldsv skjnldsv disabled auto-merge February 23, 2024 18:24
@skjnldsv skjnldsv merged commit bc3061d into nextcloud:master Feb 23, 2024
149 of 158 checks passed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamapoor fsamapoor fsamapoor approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
6 participants
@shdehnavi @ChristophWurst @fsamapoor @blizzz @solracsf @skjnldsv