Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] fix(dav): Abort requests with 429 instead of waiting #39253

Merged
merged 3 commits into from
Jul 10, 2023
Merged

[stable25] fix(dav): Abort requests with 429 instead of waiting #39253

merged 3 commits into from
Jul 10, 2023

Conversation

nickvergessen
Copy link
Member

Backport #38046

@nickvergessen
fix(dav): Abort requests with 429 instead of waiting
446ebd3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jul 10, 2023
@nickvergessen nickvergessen added this to the Nextcloud 25.0.9 milestone Jul 10, 2023
@nickvergessen nickvergessen self-assigned this Jul 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
apps/dav/lib/Connector/Sabre/Exception/TooManyRequests.php
// set ownCloud namespace
$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);

$error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests');

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method createElementNS on possibly null value
@kesselb
fix: use handleLoginFailed for invalid email address
b2776bf 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2023

Pushed a commit to fix the incomplete #37227 backport.

@kesselb
chore: fix codestyle for \OC\Files\Node\Folder
ae691e0 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2023

Pushed another commit to fix the code style for \OC\Files\Node\Folder.

@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2023

@blizzz the psalm failure looks related to #39154. Can you suggest a fix?

@blizzz blizzz mentioned this pull request Jul 10, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Jul 10, 2023

@blizzz the psalm failure looks related to #39154. Can you suggest a fix?

unrelated, ignore for now. new check we enabled.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2023
@nickvergessen nickvergessen merged commit cdc5155 into stable25 Jul 10, 2023
@nickvergessen nickvergessen deleted the backport/38046/stable25 branch July 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@kesselb kesselb kesselb approved these changes

@mejo- mejo- mejo- approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@nickvergessen nickvergessen

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25.0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @kesselb @blizzz @mejo- @bigcat88