Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] fix(dav): Abort requests with 429 instead of waiting #39255

Merged
merged 3 commits into from
Jul 10, 2023
Merged

[stable23] fix(dav): Abort requests with 429 instead of waiting #39255

merged 3 commits into from
Jul 10, 2023

Conversation

nickvergessen
Copy link
Member

Backport #38046

@nickvergessen
fix(dav): Abort requests with 429 instead of waiting
9d6a739 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jul 10, 2023
@nickvergessen nickvergessen self-assigned this Jul 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
apps/dav/lib/Connector/Sabre/Exception/TooManyRequests.php
// set ownCloud namespace
$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);

$error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests');

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method createElementNS on possibly null value
kesselb and others added 2 commits July 10, 2023 14:33
@kesselb
fix: use handleLoginFailed for invalid email address
cdad27c 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@nickvergessen
fix(tests): Adjust unit tests in backport
8c01373 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2023

image

The view, when the request is rejected, looks a bit weird. Otherwise fine.

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2023
@nickvergessen nickvergessen merged commit 4202901 into stable23 Jul 10, 2023
@nickvergessen nickvergessen deleted the backport/38046/stable23 branch July 10, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@kesselb kesselb kesselb approved these changes

@mejo- mejo- mejo- approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@nickvergessen nickvergessen

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @kesselb @juliusknorr @mejo- @bigcat88