Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] fix(dav): Abort requests with 429 instead of waiting #39256

Merged
merged 3 commits into from
Jul 10, 2023
Merged

[stable22] fix(dav): Abort requests with 429 instead of waiting #39256

merged 3 commits into from
Jul 10, 2023

Conversation

nickvergessen
Copy link
Member

Backport #38046 and #37227

kesselb and others added 3 commits July 10, 2023 06:58
@kesselb @nickvergessen
chore: use local variable for remote address
6ca2973 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb @nickvergessen
chore(tests): add tests for handleLoginFailed
43532a4 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@nickvergessen
fix(dav): Abort requests with 429 instead of waiting
da708a5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jul 10, 2023
@nickvergessen nickvergessen self-assigned this Jul 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
apps/dav/lib/Connector/Sabre/Exception/TooManyRequests.php
// set ownCloud namespace
$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);

$error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests');

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method createElementNS on possibly null value
@nickvergessen nickvergessen merged commit 149148e into stable22 Jul 10, 2023
@nickvergessen nickvergessen deleted the backport/38046/stable22 branch July 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@kesselb kesselb kesselb approved these changes

@mejo- mejo- mejo- approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @mejo- @kesselb @bigcat88