prevent recursion with log events #39366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
come-nc
and removed request for
a team
come-nc
reviewed
Jul 17, 2023
| try { | ||
| $this->eventDispatcher->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $entry)); | ||
| } catch (Throwable $e) { | ||
| // ignore exceptions from inside the logger, as trying to log them would lead to recursion |
There was a problem hiding this comment.
But that means a syntax error in BeforeMessageLoggedEvent class would go unnoticed, no?
There was a problem hiding this comment.
I guess, but that seems better than breaking any logging from such an error.
(also static analysis would detect that specific error)
There was a problem hiding this comment.
But the inLogEvent boolean is already avoiding recursion on this call, no?
There was a problem hiding this comment.
True, but an exception in the logging would still cause issues. We have similar logic in other logging places iirc
come-nc
approved these changes
Aug 1, 2023
Merged
|
Conflicts |
skjnldsv
added
2. developing
This was referenced Mar 18, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the event handling of a log event from creating more log events and causing infinite recursion.