Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add occ user:welcome command to send user welcome email from CLI #39611

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add occ user:welcome command to send user welcome email from CLI #39611

merged 2 commits into from
Aug 16, 2024

Conversation

FedericoHeichou
Copy link
Contributor

@FedericoHeichou FedericoHeichou commented Jul 28, 2023 •
edited
Loading

Summary

Implements user:welcome command.
I tested in 26 and master

TODO

  • ...

Checklist

@solracsf solracsf added 3. to review Waiting for reviews feature: occ labels Jul 28, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 28, 2023
@solracsf solracsf changed the title Add user:welcome command Add occ user:welcome command to send user welcome email from CLI Jul 28, 2023
@tanganellilore
Copy link
Contributor

Hi team,
I'm also interested to this features... @solracsf @icewind1991 can you help us to address this and include in 28?

Thanks

@FedericoHeichou FedericoHeichou force-pushed the add-command-user-welcome branch 2 times, most recently from 59ff38b to a07c9e7 Compare August 24, 2023 08:07
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team August 24, 2023 08:26
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 24, 2023
View reviewed changes
core/Command/User/Welcome.php Fixed Show resolved Hide resolved
@FedericoHeichou FedericoHeichou force-pushed the add-command-user-welcome branch from a07c9e7 to a2b220c Compare August 24, 2023 08:54
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@Altahrim
Copy link
Collaborator

@FedericoHeichou Would you mind rebasing the PR and rewrite the commit with conventional commits?

@FedericoHeichou FedericoHeichou force-pushed the add-command-user-welcome branch 2 times, most recently from 179d4c7 to 7647690 Compare March 12, 2024 15:40
This was referenced Mar 14, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@blizzz blizzz added this to the Nextcloud 30 milestone Apr 8, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@AndyScherzinger AndyScherzinger force-pushed the add-command-user-welcome branch from 7647690 to 78b8774 Compare August 7, 2024 12:20
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@sorbaugh sorbaugh reopened this Aug 16, 2024
@sorbaugh
Copy link
Contributor

Hello @FedericoHeichou, going through the PRs this one looks quite nice. I'm reopening and would like to help you get this in.

@FedericoHeichou
Copy link
Contributor Author

Hello @FedericoHeichou, going through the PRs this one looks quite nice. I'm reopening and would like to help you get this in.

Thank you, I really appreciate. I don't know why it was closed, I didn't notice it

@sorbaugh
Copy link
Contributor

We try our best to keep our PR list "up to date" by cleaning up PRs that haven't seen activity in a while (many PRs do get stale/abandoned unfortunately). We do go over PRs that get "caught" in this and push them forward again. Hope this explains a bit!

@FedericoHeichou @sorbaugh
feat: Add user:welcome command
a41e2f0 
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
@sorbaugh sorbaugh force-pushed the add-command-user-welcome branch from 78b8774 to a41e2f0 Compare August 16, 2024 08:11
@skjnldsv
fix: copyright header
6fda0c1 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 16, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 16, 2024 •
edited
Loading

Looking good!! Let's merge!! 🚀
Thank you for the patience and the great feature @FedericoHeichou 🙇 🎉

@skjnldsv skjnldsv merged commit 62f9c26 into nextcloud:master Aug 16, 2024
156 of 159 checks passed
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: occ stale Ticket or PR with no recent activity 🍀 2025-Spring
Projects
📁 Files team
Status: ☑️ Done
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Add user:welcome command
8 participants
@FedericoHeichou @tanganellilore @Altahrim @sorbaugh @skjnldsv @AndyScherzinger @blizzz @solracsf