Add files:scanAppData command #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3041 Add a dedicated command to scan the special appdata dir Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @icewind1991 to be potential reviewers. |
MorrisJobke
reviewed
Mar 22, 2017
| parent::configure(); | ||
|
|
||
| $this | ||
| ->setName('files:scanAppData') |
There was a problem hiding this comment.
I would vote for files:scan-app-data to have a common naming schema
MorrisJobke
reviewed
Mar 22, 2017
| $verbose = $input->getOption('verbose'); | ||
| $quiet = $input->getOption('quiet'); | ||
| # restrict the verbosity level to VERBOSITY_VERBOSE | ||
| if ($output->getVerbosity()>OutputInterface::VERBOSITY_VERBOSE) { |
|
And of course the autoloader is not updated. Let me address all the comments. |
Ah no - it's in files and not needed therefore. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
LukasReschke
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3041
Add a dedicated command to scan the special appdata dir