add some recrusive detection/prevention #39990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
Merged
skjnldsv
approved these changes
Feb 23, 2024
skjnldsv
force-pushed
the
recursive-share
branch
2 times, most recently
from
2e0d5bd to
e97578b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
psalm is valid |
skjnldsv
added
2. developing
nfebe
approved these changes
Feb 24, 2024
icewind1991
force-pushed
the
recursive-share
branch
3 times, most recently
from
d06e311 to
2ccd21c
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
recursive-share
branch
from
9176a0b to
d1c6e82
Compare
Merged
|
/backport to stable28 |
|
/backport to stable27 |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we try to prevent recursive shares from being created, they are known to sometimes pass through the checks, attempting to use a recursive share leads to hard to debug out of memory issues