Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the tag creator #40163

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Audit the tag creator #40163

merged 1 commit into from
Aug 1, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 30, 2023 •
edited by susnux
Loading

Summary

TODO

  • ...

Checklist

@GretaD GretaD self-assigned this Aug 30, 2023
@GretaD GretaD added the 2. developing Work in progress label Aug 30, 2023
@GretaD GretaD marked this pull request as draft August 30, 2023 13:14
@GretaD
Copy link
Contributor Author

GretaD commented Aug 30, 2023

Im not sure how to continue here:
is ok to use the console
$appActions = new Console($logger);
also, how can we get the tag of the person who added it.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 30, 2023
View reviewed changes
apps/admin_audit/lib/AppInfo/Application.php
@@ -189,6 +190,13 @@
$appActions->runCommand($event->getArguments());
});
}
private function tagHooks(IAuditLogger $logger,
IEventDispatcher $eventDispatcher): void {
$eventDispatcher->addListener(\OCP\SystemTag\ManagerEvent::EVENT_CREATE, function (\OCP\SystemTag\ManagerEvent $event) use ($logger) {

Check notice

Code scanning / Psalm

DeprecatedConstant Note

Constant OCP\SystemTag\ManagerEvent::EVENT_CREATE is deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that we deprecated it without having a replacement 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I deprecated all of the old style to make people aware that we need to update it at some point.
Also it allows us to drop the old thing sooner :P

@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@GretaD GretaD requested a review from nickvergessen May 16, 2024 13:48
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 16, 2024
@GretaD GretaD marked this pull request as ready for review May 16, 2024 13:48
@GretaD GretaD requested a review from susnux May 16, 2024 14:23
@susnux susnux requested review from a team and removed request for a team July 9, 2024 13:40
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2024
This was referenced Jul 30, 2024
Merged
Merged
@GretaD @susnux @AndyScherzinger
feat(admin_audit): Audit the tag creation
d590373 
Co-authored-by: greta <gretadoci@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: greta <gretadoci@gmail.com>
@AndyScherzinger AndyScherzinger merged commit 1ddf8d8 into master Aug 1, 2024
160 of 169 checks passed
@AndyScherzinger AndyScherzinger deleted the enhanc/audit-tag-creator branch August 1, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@GretaD GretaD

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: admin audit
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Auditing tags creators
7 participants
@GretaD @nickvergessen @AndyScherzinger @susnux @blizzz @solracsf @skjnldsv