Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved ticket support for kerberos #40165

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Saved ticket support for kerberos #40165

wants to merge 5 commits into from

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 30, 2023 •
edited
Loading

Allows saving kerberos ticket in session for reuse

  • implement some better logic about when to save tickets

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 1, 2023
View reviewed changes
apps/files_external/lib/Lib/Auth/SMB/KerberosSsoSession.php
use OCP\IL10N;
use OCP\ISession;

class KerberosSsoSession extends AuthMechanism {

Check notice

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession or in any private or final methods called in the constructor
@icewind1991 icewind1991 mentioned this pull request Sep 5, 2023
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2023
View reviewed changes
apps/files_external/lib/Lib/Auth/SMB/KerberosSsoDatabase.php
use OCP\IUser;
use OCP\Security\ICredentialsManager;

class KerberosSsoDatabase extends AuthMechanism {

Check notice

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase or in any private or final methods called in the constructor
@icewind1991 icewind1991 mentioned this pull request Sep 21, 2023
Draft
@icewind1991 icewind1991 force-pushed the kerberos-saved-ticket branch 2 times, most recently from 45ab2b9 to 13db180 Compare October 20, 2023 07:42
@icewind1991
update icewind/smb to 3.6.0
91bcb90 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Add support for saving kerberos sso ticket in session for later reuse
66ce8da 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
only save the ticket when the user is using session sso
ddd75b1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
also support saving the kerberos tickets in database
1661145 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
ci fixes
70c9f5f
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @blizzz @solracsf @skjnldsv