fix mimetype not being updated when changing file extention on objectstore #40394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
sorbaugh
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
come-nc
reviewed
Sep 21, 2023
| @@ -194,6 +194,10 @@ public function renameFromStorage(IStorage $sourceStorage, $source, $target) { | |||
|
|
|||
| $sourceInfo = $sourceCache->get($source); | |||
|
|
|||
| $sourceExtension = pathinfo($source, PATHINFO_EXTENSION); | |||
| $targetExtension = pathinfo($target, PATHINFO_EXTENSION); | |||
| $targetIsTrash = preg_match("/d\d+/", $targetExtension); | |||
There was a problem hiding this comment.
Seems fragile, shouldn’t this test if target is in files_trashbin instead?
Or at least have a regex with ^ or $, not something that can match anything in the middle.
https://www.file-extension.info/format/d3d This format for instance would match the regex while not being trash.
Comment on lines
213
to
214
| $targetExtension = pathinfo($target, PATHINFO_EXTENSION); | ||
| $targetIsTrash = preg_match("/d\d+/", $targetExtension); |
Merged
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With object store the source entry no longer exists once we hit the updater, so the old code path for changing the mimetype wasn't triggered.