Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Do not do redirect handling when loggin out" #40407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Do not do redirect handling when loggin out" #40407

wants to merge 1 commit into from

Conversation

haslersn
Copy link

This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: #16310

Checklist

@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Sep 14, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Sep 14, 2023
@kesselb
Copy link
Contributor

kesselb commented Sep 14, 2023

Good finding 👍

nickvergessen
nickvergessen reviewed Sep 19, 2023
View reviewed changes
lib/private/AppFramework/Middleware/Security/ReloadExecutionMiddleware.php

return new RedirectResponse($this->urlGenerator->linkToRouteAbsolute(
'core.login.showLoginForm',
['clear' => true] // this param the code in login.js may be removed when the "Clear-Site-Data" is working in the browsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure it does by now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logout redirect still has this code, so your question is unrelated to this PR which only removes the subsequent (i.e., 2nd) redirect. See:

server/core/Controller/LoginController.php

Line 101 in 2bd0f07

['clear' => true] // this param the code in login.js may be removed when the "Clear-Site-Data" is working in the browsers

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@haslersn
Copy link
Author

haslersn commented Nov 2, 2023

What's keeping this from getting merged?

@nickvergessen nickvergessen requested review from kesselb and removed request for rullzer November 2, 2023 09:59
@kesselb
Copy link
Contributor

kesselb commented Nov 2, 2023

What's keeping this from getting merged?

The failing DCO check, for example.
Please rebase your branch (to pull in the latest changes from master) and sign off the commits (to pass the DCO check).

@haslersn
Copy link
Author

haslersn commented Nov 2, 2023

@kesselb is was signed off, but apparently there was a mismatch between committer email and sign-off email. Should be fixed now.

This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@haslersn
Copy link
Author

What's now keeping this from getting merged?

@come-nc
Copy link
Contributor

come-nc commented Mar 12, 2024

I rebased for CI, I do not understand enough about this for approving, I’ll follow @kesselb lead on this one.

@kesselb
Copy link
Contributor

kesselb commented Mar 13, 2024

Hello Hello, it's been a while and I don't remember all the details. I think the middleware was added to address the redirect cause by clear-site-data executionContext and can, as we removed executionContext again, go.

This was referenced Mar 14, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@blizzz blizzz mentioned this pull request Apr 4, 2024
Merged
67 tasks
@haslersn
Copy link
Author

haslersn commented Apr 4, 2024

I think this can be merged.

@kesselb kesselb modified the milestones: Nextcloud 29, Nextcloud 30 Apr 4, 2024
@haslersn @kesselb
Revert "Do not do redirect handling when loggin out"
a2aea16 
This reverts commit 60e5a5e.
That commit was only required due to "executionContext" which has
since been removed. See: nextcloud#16310

Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
@kesselb kesselb requested review from a team, ArtificialOwl and sorbaugh and removed request for a team April 4, 2024 13:53
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@come-nc come-nc Awaiting requested review from come-nc

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress stale Ticket or PR with no recent activity technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haslersn @kesselb @come-nc @nickvergessen @blizzz @skjnldsv