enh(TextProcessing): Allow providers and task types to declare a dynamic ID instead of using className #41088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic ID instead of using className this allows AppAPI to register anonymous classes as TextProcessing providers and task types Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
juliusknorr,
julien-nc,
bigcat88 and
andrey18106
|
(I'm sort of sad about the loss of beauty with this, but alas) |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
6 tasks
|
@marcelklehr What did we decide to do with settings (I mean adjust it to check for new interface with ID), is there any concerns to not do it the same as for Speech-to-Text? |
Merged
|
It's not as straightforward as with the STT API, because we need to be able to instantiate task types from their id. When we are using the class name as ID it works fine, but if we're using a getId() method we need to register task types as well. I'm not sure how we can do this in a backward-compatible way. |
Merged
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Decided with @julien-nc not to have task types implementable by ExApps. Then we can keep the class names for TaskTypes and this whole thing gets a lot easier. |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Please review |
juliusknorr
reviewed
Dec 19, 2023
Comment on lines
286
to
291
| $provider = current(array_values(array_filter($providers, function ($provider) use ($preferences, $task) { | ||
| if ($provider instanceof IProviderWithId) { | ||
| return $provider->getId() === $preferences[$task->getType()]; | ||
| } | ||
| $provider::class === $preferences[$task->getType()]; | ||
| }))); |
juliusknorr
approved these changes
Dec 19, 2023
andrey18106
approved these changes
Dec 19, 2023
bigcat88
approved these changes
Dec 19, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows AppAPI to register anonymous classes as TextProcessing providers and task types
Checklist