Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize rendering for live photos #41308

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Customize rendering for live photos #41308

merged 3 commits into from
Nov 9, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 6, 2023 •
edited
Loading

Changes

  • Hide .mov file when it has a hidden=true property.
  • Show a play icon on .png file when it has a live-photo metadata.

Visuals

Screenshot from 2023-11-09 10-48-48
Screenshot from 2023-11-09 10-48-40

@artonge artonge added this to the Nextcloud 28 milestone Nov 6, 2023
@artonge artonge self-assigned this Nov 6, 2023
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from e5333dc to 404d251 Compare November 6, 2023 15:10
@artonge artonge force-pushed the artonge/feat/live_photos branch 2 times, most recently from f1bdf07 to 5da3604 Compare November 6, 2023 15:14
@artonge artonge changed the title Support live photos Customize rendering for live photos Nov 6, 2023
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from 0f7e67f to bfc40a1 Compare November 8, 2023 10:02
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 8 times, most recently from 2447b62 to 015b3c4 Compare November 8, 2023 13:46
@artonge artonge force-pushed the artonge/feat/live_photos branch 4 times, most recently from bd7e918 to 87b86b8 Compare November 8, 2023 15:06
@artonge artonge marked this pull request as ready for review November 8, 2023 15:06
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch from 015b3c4 to d3a313f Compare November 8, 2023 15:24
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2023

We should probably improve the contrast of the overlay icon like for the star icon

Do it with css

skjnldsv
skjnldsv previously requested changes Nov 8, 2023
View reviewed changes
apps/files/src/views/FilesList.vue Outdated Show resolved Hide resolved
apps/files/src/init.ts Show resolved Hide resolved
Base automatically changed from artonge/feat/metadata/port_providers to master November 8, 2023 16:58
ArtificialOwl
ArtificialOwl approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back-end part is 👍

@artonge artonge requested a review from skjnldsv November 9, 2023 09:49
@artonge artonge force-pushed the artonge/feat/live_photos branch 3 times, most recently from b5bf80e to 80a79ac Compare November 9, 2023 10:56
susnux
susnux approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

apps/dav/lib/Connector/Sabre/FilesPlugin.php Show resolved Hide resolved
apps/files/src/components/FileEntry/FileEntryPreview.vue Show resolved Hide resolved
apps/files/src/components/FileEntry/FileEntryPreview.vue Show resolved Hide resolved
apps/files/src/views/FilesList.vue Show resolved Hide resolved
@artonge artonge added the pending documentation This pull request needs an associated documentation update label Nov 9, 2023
@artonge
Copy link
Contributor Author

artonge commented Nov 9, 2023

Cypress failure unrelated

@artonge
Hide .mov for live photos
1c84139 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Display play icon over live photos' previews
b180ca9 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Compile assets
dc00904 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Copy link
Contributor Author

artonge commented Nov 9, 2023

CI failure unrelated

@artonge artonge disabled auto-merge November 9, 2023 22:53
@artonge artonge merged commit 1fe951f into master Nov 9, 2023
47 of 50 checks passed
@artonge artonge deleted the artonge/feat/live_photos branch November 9, 2023 22:53
@artonge artonge mentioned this pull request Nov 13, 2023
Closed
29 tasks
@kesselb kesselb mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement feature: files javascript pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @skjnldsv @ArtificialOwl @susnux