Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(systemtags): Add accessible system tags form #41335

Merged
merged 8 commits into from
Nov 16, 2023
Merged

enh(systemtags): Add accessible system tags form #41335

merged 8 commits into from
Nov 16, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 8, 2023 •
edited
Loading

Summary

Screenshot
Before image
After image

To Do

  • Tests

Checklist

@Pytal Pytal added this to the Nextcloud 28 milestone Nov 8, 2023
@Pytal Pytal self-assigned this Nov 8, 2023
@blizzz blizzz mentioned this pull request Nov 8, 2023
Merged
@JuliaKirschenheuter
Copy link
Contributor

😱 would need time to review

ShGKme
ShGKme approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

But from a11y perspective, I'm not sure that this is clear when this form is at the same time create and edit form, especially when searching a tag to edit is a part of the form.

apps/systemtags/src/views/SystemTagsSection.vue Show resolved Hide resolved
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal force-pushed the enh/a11y/admin-collab-tags branch from 4b2e938 to 3516f93 Compare November 9, 2023 00:33
This was referenced Nov 10, 2023
Merged
Merged
Pytal added 7 commits November 15, 2023 17:13
@Pytal
chore(systemtags): Add services for global tags and files-specific tags
e1a934d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(systemtags): Replace php markup with vue
b4b5612 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(systemtags): Export default base tag
a267dc2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(systemtags): Use files systemtags service
0983ce1 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(systemtags): Cast tag display name to string
c278079 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(systemtags): Add accessible system tags form
b1a3c4d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
3354b6b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y/admin-collab-tags branch 4 times, most recently from f670fa6 to ca35ea7 Compare November 16, 2023 02:30
@Pytal
test(systemtags): Admin system tags form
470f825 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y/admin-collab-tags branch from ca35ea7 to 470f825 Compare November 16, 2023 02:34
@Pytal Pytal merged commit 50f8d6c into master Nov 16, 2023
49 of 51 checks passed
@Pytal Pytal deleted the enh/a11y/admin-collab-tags branch November 16, 2023 04:52
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 16, 2023
This was referenced Nov 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: tags
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @susnux @ShGKme