-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): quota warning and disabled upload button #41346
Conversation
e15eaf2
to
83f04b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really liked these changes. Only comment would be if there is any way there is any way that there is less than 0 free storage space, the strict comparison with " === 0 " might not pass, and " <= 0" might be better.
But if not, I really liked the changes committed here!
/backport to stable28 |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
|
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
83f04b0
to
f89ef39
Compare
|
/backport in #42591 |
Missing from F2V
Fix #41113
Fix #41020
Quota warning
> 0
to0
This will prevent spamming with notifications and still warn people on sudden change
Upload button
This PR also fixes the Upload button not being disabled on quota exceeded
Upload error handling
Last commit also adds some better error handling
Unfortunately most of the server error messages remains untranslated, so we will use our own, despite the server potentially providing a bit more context.
but we can still merge already. This will automatically works on the next dependency update
Example:
Versus