Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic property in CalDav tests #41415

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix dynamic property in CalDav tests #41415

merged 1 commit into from
Nov 13, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 13, 2023 •
edited
Loading

  • Resolves: Creation of dynamic property OCA\DAV\Tests\unit\CalDAV\Status\StatusServiceTest::$service is deprecated

Summary

Fix dynamic property from f14a4f8#r132396755

Checklist

@come-nc
Fix dynamic property in CalDav tests
546c024 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Nov 13, 2023
@come-nc come-nc requested a review from miaulalala November 13, 2023 11:42
@come-nc come-nc self-assigned this Nov 13, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Nov 13, 2023
@miaulalala miaulalala mentioned this pull request Nov 13, 2023
Closed
4 tasks
@come-nc come-nc merged commit 4882d40 into master Nov 13, 2023
48 of 50 checks passed
@come-nc come-nc deleted the fix/fix-caldav-tests-8.3 branch November 13, 2023 12:38
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @nickvergessen @ChristophWurst @miaulalala