Allow getting the unread comment count for an entire folder at once #4146
Conversation
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @blizzz and @LukasReschke to be potential reviewers. |
rullzer
added
2. developing
|
@rullzer you haz your test |
icewind1991
added
3. to review
lib/private/Comments/Manager.php
Outdated
| ->innerJoin('c', 'filecache', 'f', $qb->expr()->andX( | ||
| $qb->expr()->eq('c.object_type', $qb->createNamedParameter('files')), | ||
| $qb->expr()->eq('f.fileid', $qb->createFunction( | ||
| 'cast(' . $qb->getColumnName('c.object_id') . ' as ' . $castAs . ')' |
There was a problem hiding this comment.
Please use $query->expr()->castColumn()
|
@icewind1991 tests are failing... |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unread-comments-folder
branch
from
8f22a3f to
11c1e5d
Compare
|
@rullzer all green |
| $parentPath = '/'; | ||
| } | ||
| // if we already cached the folder this file is in we know there are no shares for this file | ||
| if (array_search($parentPath, $this->cachedFolders) === false) { |
There was a problem hiding this comment.
It's faster to use the $parentPath as key and checking it's presence. OTOH, there won't be much in this cache, will it?
There was a problem hiding this comment.
I prefer to use a regular array and array_search here, performance shouldn't matter since this entire branch is an edge case anyway
| * @return array [$fileId => $unreadCount] | ||
| * @since 12.0.0 | ||
| */ | ||
| public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user); |
There was a problem hiding this comment.
Release notes, if we had them, would be a good place to mention this addition :)
Instead of doing 2 queries per file in a folder, we do a single query to get all unread comment counts.
comparison with 100 files