fix(files): Ensure folders and favorites are sorted first regardless of sorting mode #41519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/files-sorting
branch
from
d4c5aa2 to
ae711a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Merged
|
@nickvergessen resolved - waiting for reviews. |
susnux
force-pushed
the
fix/files-sorting
branch
from
ae711a0 to
96dd30a
Compare
susnux
changed the title
artonge
reviewed
Nov 16, 2023
| this.isAscSorting ? 'asc' : 'desc', | ||
| this.isAscSorting ? 'asc' : 'desc', | ||
| ] | ||
| return [identifiers, orders] as const |
There was a problem hiding this comment.
Yes otherwise the type would be (v => bool | string)[] using const the type is [v => bool, string] making it obvious that this only returns an array with exactly two elements. So that we can deconstruct it for orderBy
AndyScherzinger
approved these changes
Nov 16, 2023
…or sorting order Also fixes `mtime` being wrong sorted, as high mtime means recently edited -> lower Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-sorting
branch
from
96dd30a to
1be7eb1
Compare
artonge
approved these changes
Nov 16, 2023
|
/compile amend/ |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
blizzz
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add fixed sorting mode for "folder before files" and "favorites before other" - meaning those should if configured sorted before even for descending.
Checklist