Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate opcache check to new SetupCheck API #41547

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Migrate opcache check to new SetupCheck API #41547

merged 5 commits into from
Jan 8, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 16, 2023 •
edited
Loading

Summary

Migrate opcache check to new SetupCheck API

TODO

  • Decide what to do with <code> tags.

Checklist

@come-nc come-nc added the 2. developing Work in progress label Nov 16, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Nov 16, 2023
@come-nc come-nc self-assigned this Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@come-nc come-nc force-pushed the feat/merge-sqlite-check-to-database-check branch from 47bf97f to 09c67c5 Compare November 28, 2023 15:24
@come-nc come-nc mentioned this pull request Nov 28, 2023
Closed
33 tasks
@come-nc come-nc force-pushed the feat/merge-sqlite-check-to-database-check branch from 09c67c5 to 95ea46c Compare December 7, 2023 14:45
@come-nc come-nc force-pushed the feat/migrate-opcache-check-to-new-api branch from 7ee93fb to a9c6381 Compare December 11, 2023 13:48
Base automatically changed from feat/merge-sqlite-check-to-database-check to master December 11, 2023 14:00
@come-nc come-nc force-pushed the feat/migrate-opcache-check-to-new-api branch from a9c6381 to 114c0eb Compare December 12, 2023 08:35
@come-nc
Copy link
Contributor Author

come-nc commented Dec 12, 2023

For the <code> tags, I used quotes for now, if/when we add rich text support to setupchecks we can replace those.

@come-nc come-nc marked this pull request as ready for review December 12, 2023 15:15
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 12, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and Altahrim and removed request for a team December 12, 2023 15:16
@come-nc come-nc mentioned this pull request Dec 14, 2023
Merged
4 tasks
come-nc added 3 commits January 8, 2024 15:09
@come-nc
Migrate opcache check to new SetupCheck API
3f13a1a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove unused properties from CheckSetupControllerTest
989b5ff 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove unsupported <code> tag and use quotes instead
f6df5da 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix small psalm issue
c92fbca 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-opcache-check-to-new-api branch from 72b1474 to e832c14 Compare January 8, 2024 14:09
@come-nc
Improve PHP opcache setup check and reduce level in some cases
94d0399 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-opcache-check-to-new-api branch from e832c14 to 94d0399 Compare January 8, 2024 15:03
@come-nc come-nc requested a review from artonge January 8, 2024 15:15
artonge
artonge approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything changed beside moving code and adapting tests?

@come-nc
Copy link
Contributor Author

come-nc commented Jan 8, 2024

Failure not related, see #42633

@come-nc
Copy link
Contributor Author

come-nc commented Jan 8, 2024

Anything changed beside moving code and adapting tests?

Yes, level is error or warninig depending on which recommendation is triggered, saw that with Benjamin.

@come-nc come-nc merged commit adfe883 into master Jan 8, 2024
49 of 50 checks passed
@come-nc come-nc deleted the feat/migrate-opcache-check-to-new-api branch January 8, 2024 16:35
@come-nc come-nc mentioned this pull request Jan 15, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @Altahrim @artonge @blizzz