-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): move actions for selected file out from table header #41972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
fix/41834/files--a11y-actions-on-selected
branch
from
January 8, 2024 15:10
448d533
to
55e6940
Compare
ShGKme
requested review from
skjnldsv,
susnux,
JuliaKirschenheuter and
Pytal
and removed request for
skjnldsv
January 8, 2024 15:22
ShGKme
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 8, 2024
ShGKme
force-pushed
the
fix/41834/files--a11y-actions-on-selected
branch
from
January 8, 2024 15:29
55e6940
to
f30379e
Compare
Pytal
reviewed
Jan 8, 2024
Pytal
approved these changes
Jan 8, 2024
ShGKme
force-pushed
the
fix/41834/files--a11y-actions-on-selected
branch
from
January 8, 2024 19:18
f30379e
to
64924c1
Compare
skjnldsv
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 10, 2024
Having actions in the table header is no valid for a11y and counts as a column name. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/41834/files--a11y-actions-on-selected
branch
from
January 10, 2024 16:57
64924c1
to
0f96a98
Compare
Rebased onto |
/backport b1a9017 to stable28 |
🥳🥳 great! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rendering actions button inside the table column header still counts as the table header. As the result:
In this PR actions are moved out from the table and table header is always rendered.
TODO
FilesListTableHeaderActions
is now a<div>
, not a table header cell<th>
VirtualList
has a new slot#header-overlay
to display content with absolute position above the headerFilesListVirtual
passes<FilesListTableHeaderActions>
to the new#header-overlay
slotFilesListTableHeader
doesn't render<FilesListTabelHeaderActions>
and always render table header (Screen Reader NVDA
Screenshots - no visual changes
Checklist