Add UserConfigChangedEvent to fire whenever a user config value is changed #42039
+111
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akhil1508
commented
Dec 5, 2023
akhil1508
commented
- For Can we fire UserChangedEvent when setUserValue method is used? #41938
akhil1508
commented
Dec 5, 2023
|
|
||
| private function triggerUserValueChange($userId, $appId, $key, $value, $oldValue = null) { | ||
| if (\OC::$server instanceof \OCP\IServerContainer) { | ||
| $dispatcher = \OC::$server->get(IEventDispatcher::class); |
There was a problem hiding this comment.
Cannot use DI for this as it is used in base.php over here
There was a problem hiding this comment.
Is that the right link? The Allconfig constructor does not call setUserValue.
There was a problem hiding this comment.
@come-nc I believe I meant to say:
AllConfigis instantiated inbase.phpasnew \OC\AllConfig(new \OC\SystemConfig(self::$config))- If I add
IEventListener $eventListenerin the constructor for DI in this class (the usual way), it could be problematic. I remember it causing errors when I first wrote this code, but maybe I should re-test? 🤔
There was a problem hiding this comment.
Yes please, the event listener is available early so I would be surprised if this is called even earlier. Maybe for login time 🤔
If some value change call do not trigger the event we need to document that.
Merged
akhil1508
force-pushed
the
dev/user-preference-event
branch
4 times, most recently
from
037ad05
to
b040664
Compare
akhil1508
changed the title
|
Hey @akhil1508 |
skjnldsv
requested review from
artonge,
come-nc,
a team and
ArtificialOwl
and removed request for
a team
skjnldsv
added
enhancement
3. to review
come-nc
reviewed
Sep 16, 2024
|
|
||
| private function triggerUserValueChange($userId, $appId, $key, $value, $oldValue = null) { | ||
| if (\OC::$server instanceof \OCP\IServerContainer) { | ||
| $dispatcher = \OC::$server->get(IEventDispatcher::class); |
There was a problem hiding this comment.
Is that the right link? The Allconfig constructor does not call setUserValue.
akhil1508
force-pushed
the
dev/user-preference-event
branch
from
0b331d0
to
57d68a3
Compare
Signed-off-by: Akhil <akhil@e.email>
Signed-off-by: Akhil <akhil@e.email>
Signed-off-by: Akhil <akhil@e.email>
akhil1508
force-pushed
the
dev/user-preference-event
branch
from
57d68a3
to
3040493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.