Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dashboard): Lower error to info log message #42768

Merged
merged 2 commits into from
Jan 15, 2024
Merged

(dashboard): Lower error to info log message #42768

merged 2 commits into from
Jan 15, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jan 14, 2024

Summary

Actually this is being logged as an error but there is no error.

image

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added this to the Nextcloud 29 milestone Jan 14, 2024
@solracsf
Copy link
Member Author

/backport to stable28

@solracsf
Copy link
Member Author

/backport to stable27

@solracsf solracsf changed the title (dashboard): Lower error to warning log message (dashboard): Lower error to info log message Jan 15, 2024
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a fraction of the code is taking 1s to load, it usually indicates a coding error in the app or configuration error on the server.
But yeah, we can downgrade it for now

@solracsf solracsf merged commit 32bf74a into master Jan 15, 2024
50 checks passed
@solracsf solracsf deleted the errorToWarn branch January 15, 2024 10:38
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@solracsf
Copy link
Member Author

/skjnldsv-backport to stable28

@solracsf
Copy link
Member Author

/skjnldsv-backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants