Remove obsolete check of curl SSL version #42807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
come-nc
force-pushed
the
enh/migrate-cron-setupcheck
branch
2 times, most recently
from
34c77ac
to
9bdad44
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/remove-curl-obsolete-ssl-check
branch
from
77a0e56
to
0e889da
Compare
susnux
approved these changes
Jan 16, 2024
Altahrim
approved these changes
Jan 17, 2024
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
This check comment links to a github issue stating that already in 2015 all major distributions were not distributing a problematic version anymore. It also relied on a weird heuristic using Nextcloud website to try to detect if the SSL lib has a specific bug.
It makes more sense to remove it than to try to migrate it to new API.
Checklist