Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate available temp space check to new SetupCheck API #42839

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 16, 2024

See #41364

Summary

Migrate available temp space check to new SetupCheck API.
Also put info in the check and not in the log file.

  • See whether is makes sense to display available temp space even if not s3 based?

Checklist

@come-nc come-nc added the 2. developing Work in progress label Jan 16, 2024
@come-nc come-nc self-assigned this Jan 16, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Jan 16, 2024

isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed uses sys_get_temp_dir but temporaryDirectoryWritable uses the ITempManager, which has a more complex way of find temp directory path.

I think it would make sense to merge both checks and always use path from ITempManager as that is what Nextcloud and apps should use. But we need to be sure this is what is used for uploads with an s3 backend.

@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 22, 2024
@come-nc come-nc requested review from nickvergessen, susnux, a team, ArtificialOwl, Altahrim and Fenn-CS and removed request for a team January 22, 2024 13:28
@come-nc come-nc force-pushed the enh/migrate-mysql-utf8mb4-setupcheck branch 2 times, most recently from 2916812 to 10664e9 Compare January 23, 2024 16:34
Base automatically changed from enh/migrate-mysql-utf8mb4-setupcheck to master January 25, 2024 10:18
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
It will now show available space and path of both PHP and Nextcloud
 temporary directories if they differ.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/migrate-s3tempspace-setupcheck branch from 200804e to 9add64f Compare January 25, 2024 10:48
@come-nc come-nc marked this pull request as ready for review January 25, 2024 10:48
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 25, 2024
@nickvergessen nickvergessen merged commit 7c79521 into master Jan 25, 2024
55 checks passed
@nickvergessen nickvergessen deleted the enh/migrate-s3tempspace-setupcheck branch January 25, 2024 12:04
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants