Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Apply same logic on capabilities for primary color as done on themes #43033

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 22, 2024

Summary

On themes we replace the default color with the accessible color, so we also need to do this on the capabilities.
This worked previously but as we now enforce contrasts of the text color clients that use the capabilities changes to black text on that color.

Checklist

@susnux susnux force-pushed the fix/color-capabilities branch 2 times, most recently from 07e8672 to cfbca20 Compare January 22, 2024 19:53
… on themes

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Jan 23, 2024

Maybe we should after all fix this in OCA\ThemingDefaults instead. Because that would fix #43043
(even if that means more tests need to be adjusted, as we basically then will nowhere have the default color anymore but just the default accessible color).

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@susnux susnux merged commit 8ba7de8 into master Jan 23, 2024
52 of 53 checks passed
@susnux susnux deleted the fix/color-capabilities branch January 23, 2024 17:32
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: theming regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants