[stable28] Move modal outside of the Version component. #43167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
emoral435,
nfebe,
JuliaKirschenheuter,
ShGKme and
artonge
backportbot
bot
added
3. to review
|
/compile amend/ |
emoral435
approved these changes
Jan 30, 2024
JuliaKirschenheuter
approved these changes
Jan 30, 2024
|
@emoral435 next time, feel free to check the checkbox in the main comment, and to set the PR as ready to review ;). |
|
@artonge Gotcha! My bad 😓 |
JuliaKirschenheuter
force-pushed
the
backport/43084/stable28
branch
2 times, most recently
from
d489775 to
888d591
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/43084/stable28
branch
from
1dc1342 to
000668d
Compare
JuliaKirschenheuter
force-pushed
the
backport/43084/stable28
branch
from
000668d to
04c16e6
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/43084/stable28
branch
from
04c16e6 to
ade36fb
Compare
JuliaKirschenheuter
force-pushed
the
backport/43084/stable28
branch
from
ade36fb to
454ac4a
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/43084/stable28
branch
from
454ac4a to
90ca3d5
Compare
This is for accessibility, to have the NcListItem (<li>) as a direct child of the <ul> Signed-off-by: Louis Chemineau <louis@chmn.me>
JuliaKirschenheuter
force-pushed
the
backport/43084/stable28
branch
from
90ca3d5 to
dec15ac
Compare
susnux
force-pushed
the
backport/43084/stable28
branch
from
dec15ac to
5987b97
Compare
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/43084/stable28
branch
from
5987b97 to
b65c5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43084
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
[skip ci]tagLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.