-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(occ): add possibility to edit indices #43209
Conversation
Note to myself: Somehow we have to make clear that it is mandatory to change the name of the index to prevent execution on every db:add-missing-indices. |
We could call it replace instead of edit to make the intent clear :) |
I changed the output of dry-run to improve readability: before:
after:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
575088f
to
c753144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
c753144
to
9c9ed25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Conventional commits are now enforced for this repo. Please change the commit title to |
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
9c9ed25
to
06d0764
Compare
Summary
To be able to edit indices, this pr extend the
occ db:add-missing-indices
by the this possibility.This is important if there is an index that need to be edited (deleting and right after that adding indices).
Use cases:
Contributes to: nextcloud/mail#9162
TODO
Checklist