Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user_status): Fix losing focus to body when closing user status modal #43271

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix(user_status): Fix losing focus to body when closing user status modal #43271

merged 2 commits into from
Feb 2, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 1, 2024

Summary

Checklist

Pytal added 2 commits February 1, 2024 11:37
@Pytal
fix(user_status): Fix losing focus to body when closing user status m…
a6fac21 
…odal

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
b7d906a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 29 milestone Feb 1, 2024
@Pytal Pytal self-assigned this Feb 1, 2024
@Pytal
Copy link
Member Author

Pytal commented Feb 1, 2024

/backport a6fac21 to stable28

@Pytal Pytal enabled auto-merge February 1, 2024 19:59
emoral435
emoral435 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean solution. And also nice catch on the issue, code is clean!

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@Pytal Pytal merged commit 995ccb5 into master Feb 2, 2024
90 of 94 checks passed
@Pytal Pytal deleted the fix/a11y/status-return-focus branch February 2, 2024 13:36
@backportbot backportbot bot mentioned this pull request Feb 2, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility bug feature: status
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[BITV] Focus is lost to body when closing user status modal
3 participants
@Pytal @JuliaKirschenheuter @emoral435