enh: update desktop client unsupported version (403) error message #43281

camilasan · 2024-02-02T09:42:15Z

The user should get a more friendly warning when their desktop client version is not supported anymore by the server. See #nextcloud/desktop/issues/6273

Before:

After:

Systray message

Resolves: Display a message to upgrade client if minimumSupportedDesktopVersion is thrown desktop#6273

Summary

TODO

...

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

solracsf

Tests must be fixed.

solracsf · 2024-02-06T11:29:33Z

What about adding a link on the message to customclient_desktop link?
This could lead to a better UX after all (upgrade one-click away!) :)

server/config/config.sample.php

Lines 1105 to 1117 in ee6a62a

    
           /** 
        
            * This section is for configuring the download links for Nextcloud clients, as 
        
            * seen in the first-run wizard and on Personal pages. 
        
            * 
        
            * Defaults to: 
        
            * 
        
            * - Desktop client: ``https://nextcloud.com/install/#install-clients`` 
        
            * - Android client: ``https://play.google.com/store/apps/details?id=com.nextcloud.client`` 
        
            * - iOS client: ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8`` 
        
            * - iOS client app id: ``1125420102`` 
        
            */ 
        
           'customclient_desktop' => 
        
           	'https://nextcloud.com/install/#install-clients',

camilasan · 2024-02-08T17:42:50Z

What about adding a link on the message to customclient_desktop link?
This could lead to a better UX after all (upgrade one-click away!) :)

@nextcloud/designers what do you think?

camilasan · 2024-02-08T19:44:16Z

Tests must be fixed.

I don't know how to fix the tests. I tried to run it locally:
An unhandled exception has been thrown:
Exception: Environment not properly prepared

I need help.

solracsf · 2024-02-08T20:59:01Z

@camilasan I was more thinking about a clickable link (if it can be done).
Somethiing like:

The current version of Nextcloud Desktop client is not supported by this server (client version 3.11+ is required).`
Go to Nextcloud Downloads page to download the update.

Otherwise, the full link is too much noise IMO :(

nimishavijay · 2024-02-12T15:15:04Z

Agreed with @solracsf that the link could be hidden. What do you think about adding the link to the text "version 3.0.0 or later"? Would that be possible :)

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later.

camilasan · 2024-02-22T13:24:15Z

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later.

done, please review @solracsf

solracsf

Fine by me. 👍
Maybe just update the 1st post with an updated screenshot of the final version.

jancborchardt

Seems good if it’s a clickable link like @solracsf suggested. :)

Another detail: In the settings it says "Unable to connect to Nextcloud" and in the notification "Network error" – both of these are different and neither really seem correct for the issue?
Maybe rather it should say "Connection issue" @camilasan?

camilasan · 2024-03-06T17:10:43Z

Maybe rather it should say "Connection issue" @camilasan?

I changed it here: nextcloud/desktop#6514

since the message reason may vary, I think 'Connection issue' is better.

@jancborchardt I didn't realize your comment only referred to the strings used in the desktop client. So this PR on the server is actually done.

* The user should get a more friendly warning when their desktop client version is not supported anymore by the server. See #nextcloud/desktop/issues/6273 * Update BlockLegacyClientPluginTest to reflect the new 403 error message. Signed-off-by: Camila Ayres <hello@camilasan.com>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

solracsf · 2024-09-07T17:02:42Z

apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

+			$customClientDesktopLink = htmlspecialchars($this->themingDefaults->getSyncClientUrl());
+			$minimumSupportedDesktopVersion = htmlspecialchars($minimumSupportedDesktopVersion);
+
+			throw new \Sabre\DAV\Exception\Forbidden("This version of the client is unsupported. Upgrade to <a href=\"$customClientDesktopLink\">version $minimumSupportedDesktopVersion or later</a>.");


Ideally, this should be a translated string 😿
Maybe in a follow-up PR.

camilasan marked this pull request as draft February 2, 2024 09:47

camilasan requested review from jancborchardt and nimishavijay February 2, 2024 10:41

camilasan force-pushed the feature/minSupportDesktopVerMsg branch from d5db7bc to 6e513f7 Compare February 2, 2024 10:44

camilasan marked this pull request as ready for review February 2, 2024 10:44

camilasan mentioned this pull request Feb 2, 2024

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown nextcloud/desktop#6273

Closed

solracsf added 3. to review Waiting for reviews client: 💻 desktop labels Feb 2, 2024

solracsf added this to the Nextcloud 29 milestone Feb 2, 2024

camilasan mentioned this pull request Feb 2, 2024

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown nextcloud/desktop#6405

Merged

2 tasks

solracsf requested changes Feb 3, 2024

View reviewed changes

camilasan force-pushed the feature/minSupportDesktopVerMsg branch 2 times, most recently from b9e4df9 to 7a10ed0 Compare February 8, 2024 17:42

camilasan force-pushed the feature/minSupportDesktopVerMsg branch from 7a10ed0 to 494f87c Compare February 8, 2024 17:45

camilasan force-pushed the feature/minSupportDesktopVerMsg branch 2 times, most recently from e071f1b to 7670c30 Compare February 22, 2024 13:20

solracsf approved these changes Feb 22, 2024

View reviewed changes

solracsf changed the title ~~Update 403 error message.~~ enh: update desktop client unsupported version (403) error message Feb 26, 2024

jancborchardt requested changes Feb 28, 2024

View reviewed changes

camilasan mentioned this pull request Mar 6, 2024

User 'Connection issue' instead of 'Network error' in systray notification nextcloud/desktop#6514

Merged

jancborchardt approved these changes Mar 6, 2024

View reviewed changes

This was referenced Mar 12, 2024

29.0.0 beta 2 #44152

Merged

29.0.0 beta 3 #44186

Merged

skjnldsv mentioned this pull request Mar 28, 2024

29.0.0 RC1 #44552

Merged

81 tasks

This was referenced Apr 4, 2024

29.0.0 RC2 #44647

Merged

29.0.0 RC3 #44713

Merged

blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024

skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024

This was referenced Jul 30, 2024

30.0.0 beta 2 #46870

Merged

30.0.0 beta 3 #46946

Merged

This was referenced Aug 5, 2024

30.0.0 beta 4 #47028

Merged

30.0.0 beta 5 #47100

Merged

skjnldsv mentioned this pull request Aug 13, 2024

30.0.0 RC1 #47190

Merged

skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024

susnux force-pushed the feature/minSupportDesktopVerMsg branch from 7670c30 to 6f8918a Compare September 6, 2024 10:35

susnux requested review from ChristophWurst, miaulalala and tcitworld as code owners September 6, 2024 12:40

susnux force-pushed the feature/minSupportDesktopVerMsg branch from 935cef4 to f94ab7f Compare September 6, 2024 14:59

camilasan and others added 2 commits September 6, 2024 17:15

fix: Adjust unit tests and protect against XSS

5fc715a

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux force-pushed the feature/minSupportDesktopVerMsg branch from f94ab7f to 5fc715a Compare September 6, 2024 15:16

susnux approved these changes Sep 7, 2024

View reviewed changes

susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Sep 7, 2024

susnux merged commit 46472d3 into master Sep 7, 2024
174 checks passed

susnux deleted the feature/minSupportDesktopVerMsg branch September 7, 2024 14:24

solracsf reviewed Sep 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enh: update desktop client unsupported version (403) error message #43281

enh: update desktop client unsupported version (403) error message #43281

camilasan commented Feb 2, 2024 •

edited

Loading

solracsf left a comment

solracsf commented Feb 6, 2024

camilasan commented Feb 8, 2024

camilasan commented Feb 8, 2024

solracsf commented Feb 8, 2024 •

edited

Loading

nimishavijay commented Feb 12, 2024 •

edited

Loading

camilasan commented Feb 22, 2024

solracsf left a comment

jancborchardt left a comment

camilasan commented Mar 6, 2024 •

edited

Loading

solracsf Sep 7, 2024

enh: update desktop client unsupported version (403) error message #43281

enh: update desktop client unsupported version (403) error message #43281

Conversation

camilasan commented Feb 2, 2024 • edited Loading

Before:

After:

Systray message

Summary

TODO

Checklist

solracsf left a comment

Choose a reason for hiding this comment

solracsf commented Feb 6, 2024

camilasan commented Feb 8, 2024

camilasan commented Feb 8, 2024

solracsf commented Feb 8, 2024 • edited Loading

nimishavijay commented Feb 12, 2024 • edited Loading

camilasan commented Feb 22, 2024

solracsf left a comment

Choose a reason for hiding this comment

jancborchardt left a comment

Choose a reason for hiding this comment

camilasan commented Mar 6, 2024 • edited Loading

solracsf Sep 7, 2024

Choose a reason for hiding this comment

camilasan commented Feb 2, 2024 •

edited

Loading

solracsf commented Feb 8, 2024 •

edited

Loading

nimishavijay commented Feb 12, 2024 •

edited

Loading

camilasan commented Mar 6, 2024 •

edited

Loading