-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AccountPlusIcon in broadcrombs #43433
Conversation
6e97ea8
to
e91fdad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)
162fb15
to
bac1b13
Compare
Should be fixed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test the code but seems good
This comment was marked as resolved.
This comment was marked as resolved.
bac1b13
to
7981bf8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
this does NOT ignore conflicts |
Yeah, figured that out already 😅😥 |
7981bf8
to
0dbbdea
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Simon L <szaimen@e.mail.de>
0dbbdea
to
a183a23
Compare
/backport to stable28 |
Use AccountPlusIcon in broadcrombs
Close #40202
Close #42502
Supercedes #42502
For my own testing