Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AccountPlusIcon in broadcrombs #43433

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 7, 2024

Close #40202
Close #42502
Supercedes #42502

Before After
image image
For my own testing
docker run -it --rm ^
--name nextcloud-easy-test1 ^
-p 8444:443 ^
-e SERVER_BRANCH=enh/40202/use-correct-icon ^
-e COMPILE_SERVER=1 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Feb 7, 2024
@szaimen szaimen added this to the Nextcloud 29 milestone Feb 7, 2024
@szaimen szaimen force-pushed the enh/40202/use-correct-icon branch 2 times, most recently from 6e97ea8 to e91fdad Compare February 7, 2024 13:15
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2024
@szaimen szaimen marked this pull request as ready for review February 7, 2024 13:25
@szaimen szaimen requested a review from skjnldsv as a code owner February 7, 2024 13:25
@szaimen szaimen mentioned this pull request Feb 7, 2024
5 tasks
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)

@szaimen szaimen force-pushed the enh/40202/use-correct-icon branch 2 times, most recently from 162fb15 to bac1b13 Compare February 7, 2024 14:08
@szaimen
Copy link
Contributor Author

szaimen commented Feb 7, 2024

Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)

Should be fixed now :)

@szaimen szaimen requested a review from jancborchardt February 7, 2024 14:08
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test the code but seems good

@szaimen

This comment was marked as resolved.

@szaimen szaimen enabled auto-merge February 7, 2024 19:08
@nextcloud-command nextcloud-command force-pushed the enh/40202/use-correct-icon branch from bac1b13 to 7981bf8 Compare February 7, 2024 19:14
@szaimen

This comment was marked as resolved.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2024

/compile rebase /

this does NOT ignore conflicts

@szaimen
Copy link
Contributor Author

szaimen commented Feb 8, 2024

/compile rebase /

this does NOT ignore conflicts

Yeah, figured that out already 😅😥

@szaimen szaimen force-pushed the enh/40202/use-correct-icon branch from 7981bf8 to 0dbbdea Compare February 8, 2024 09:42
@szaimen

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the enh/40202/use-correct-icon branch from 0dbbdea to a183a23 Compare February 8, 2024 10:01
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 8, 2024
@szaimen szaimen merged commit d247d35 into master Feb 8, 2024
85 checks passed
@szaimen szaimen deleted the enh/40202/use-correct-icon branch February 8, 2024 10:49
@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2024

/backport to stable28

artonge pushed a commit that referenced this pull request Feb 8, 2024
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust icon of shared state in broadcrumb
4 participants