enh: Add details to CodeIntegrity setup check #43575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
come-nc
reviewed
Feb 19, 2024
| } | ||
| } else { | ||
| foreach ($result as $key => $results) { | ||
| $formattedTextResponse .= "\t\t- $results\n"; |
There was a problem hiding this comment.
Should $results be escaped for markdown special chars?
Also, these complete results will show in occ setupchecks output and in standard admin page, no?
Should we add there some special handling to see double new-line as an end of summary?
susnux
commented
Feb 19, 2024
| @@ -1270,6 +1270,7 @@ doesnotexist:-o-prefocus, .strengthify-wrapper { | |||
|
|
|||
| li { | |||
| margin: 10px 0; | |||
| white-space: pre-wrap; | |||
There was a problem hiding this comment.
@come-nc this one is for the admin settings page to show the output correctly.
skjnldsv
approved these changes
Mar 15, 2024
This was referenced Mar 18, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more details so that users of the setup checks can visualize the status better (security guard).
Checklist