Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Dont't warn re: full on either zero or unlimited quota #43666

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(files): Dont't warn re: full on either zero or unlimited quota #43666

merged 1 commit into from
Feb 20, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Feb 19, 2024 •
edited
Loading

Fixes #43535
Fixes #43280

Summary

Replaces #43544 (Thanks @jkhradil!) in order to be able to cleanly compile assets (hopefully) + add fix for unlimited quotas too

TODO

Checklist

@joshtrichards joshtrichards added this to the Nextcloud 28.0.3 milestone Feb 19, 2024
@joshtrichards

This comment was marked as resolved.

Sign in to view
@joshtrichards @nextcloud-command
fix(files): Dont't warn re: full storage on either zero or unlimited …
aff8b56 
…quotas

Fixes #43535
Fixes #43280

Replaces #43544

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/files-quota-warnings-zero-and-unlimited branch from 9c0e6fe to aff8b56 Compare February 19, 2024 22:59
@joshtrichards joshtrichards mentioned this pull request Feb 19, 2024
Closed
4 tasks
@joshtrichards joshtrichards requested a review from susnux February 19, 2024 23:06
@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards joshtrichards changed the title fix(files): Dont't warn re: full storage on either zero or unlimited … fix(files): Dont't warn re: full on either zero or unlimited quota Feb 19, 2024
@skjnldsv skjnldsv enabled auto-merge February 20, 2024 09:27
@skjnldsv skjnldsv merged commit 2dfc389 into master Feb 20, 2024
97 checks passed
@skjnldsv skjnldsv deleted the fix/files-quota-warnings-zero-and-unlimited branch February 20, 2024 09:29
@backportbot backportbot bot mentioned this pull request Feb 20, 2024
Merged
2 tasks
@skjnldsv

This comment was marked as resolved.

Sign in to view
@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Sep 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Altahrim Altahrim Altahrim approved these changes

@susnux susnux Awaiting requested review from susnux

@nfebe nfebe Awaiting requested review from nfebe

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug feature: external storage feature: files regression
Projects
None yet
Milestone
Nextcloud 29
4 participants
@joshtrichards @skjnldsv @Altahrim @solracsf