feat(oauth2): simple userinfo endpoint

[hardviper]

Summary

This solves the oAuth2 authorization issue in openproject when openproject is the client.
Added endpoint that returns a minimum set of user information.
This is very necessary in my openproject integration with nextcloud.
I hope this helps someone else.
Thanks to @jlallana for suggesting this solution in PR #19934.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
  • \OCA\OAuth2\Tests\Controller\OauthApiControllerTest
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[hardviper]

@skjnldsv Is there anything else I can add to help you accept this?

[skjnldsv]

@skjnldsv Is there anything else I can add to help you accept this?

I pinged the proper devs, let's see :)
Does this supersede #19934 ?

[hardviper]

@skjnldsv This adds the user_info endpoint, but does not add the discovery.
Now I have fixed the problem noted by the bot, and also added some more userinfo fields.

[skjnldsv]

There was an issue with the rebase, please fix it

[hardviper]

@skjnldsv Ready! I have corrected! I don't understand how these commits got here.

[ChristophWurst]

I'm fine with the endpoint. Some instructions for testing would be appreciated.

The name split logic probably doesn't work for all names. If we can I would strongly favor removing it and only exposing the full name.

[kesselb]

Thanks for your pull request 👍

I'm against the process_name feature even as optional. Once merged, we have to maintain and support it. Furthermore, we cannot just drop the feature when people started using it and rely on it. But the approach is just wrong, and a similar approach in CardDAV (Converter.splitFullName) already caused trouble.

[hardviper]

@kesselb Thank you for your time and feedback on my pull request!
I understand your concerns about supporting the new feature and I want to discuss a few points.
Endpoint was developed by me to integrate with OpenProject, without name separation, my integration does not work. Name separation expands the capabilities and improves the overall functionality of nextcloud. There are probably OAuth2 clients that also necessarily need separated names. The result that my code returns is consistent with the OpenID specification. The functionality that causes your concerns is additional and does not affect the existing functionality. Users can choose whether they want to use this feature or not. I am ready to support and develop this feature after its implementation. The code is covered with tests, this will help to avoid problems and simplify the support of the function in the future.
I looked at the CardDAV code (Converter.splitFullName), in my opinion, name separation is implemented much more flexibly and fault-tolerant here. Tell us what problems you had to face with CardDAV (Converter.splitFullName)? Perhaps I can add something here that will save my code from the problems that you have encountered? I am open to further discussions and ready to make any necessary changes.

[hardviper]

@julien-nc @kesselb @ChristophWurst @skjnldsv I suggest we return to the discussion of PR. Is there anything else I can do to convince you to accept my contribution?

[kesselb]

The approach to split the full name by a given character assumes that every name follows the same pattern.

Please look at https://en.wikipedia.org/wiki/Personal_name to get a better understanding how different personal names are.

To solve this problem, we need our own fields to store first name/last name and make the full name a getter from them.

I assume you can still implement this endpoint via your own Nextcloud app.

[hardviper]

To solve this problem, we need our own fields to store first name/last name and make the full name a getter from them.

@kesselb Is there an addition of last name and first name fields in the roadmap?

[kesselb]

Is there an addition of last name and first name fields in the roadmap?

Forwarded your question.
Please ping me if we haven't replied within the next 4 weeks.

[hardviper]

@kesselb Do you have an answer for the roadmap?

[kesselb]

Do you have an answer for the roadmap?

Having fields for first name, last name, title or prefix as addition/replacement for the full name field is something we want.

However, it's not scheduled for the current or next iteration.

https://github.com/H2CK/oidc could be interesting for you as well.